Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle the exit code returned from main() #79

Closed
elliotchance opened this issue May 4, 2017 · 0 comments
Closed

Correctly handle the exit code returned from main() #79

elliotchance opened this issue May 4, 2017 · 0 comments
Labels
a: small c: syntax d: bug
Milestone
v0.10.x

Comments

@elliotchance
Copy link
Owner

The main function in Go does not return a value. c2go will discard the return value so the program will always finish with a successful exit code.

We need to recognise the return in the main function and call the system exit so that the correct status is passed back to the calling process.

Search for "issues/79" in the codebase.
@elliotchance elliotchance added this to the Future Release milestone May 4, 2017
x-tyger added a commit to x-tyger/c2go that referenced this issue May 10, 2017
@x-tyger
Use os.Exit() for ReturnStmt in main(). Fixes elliotchance#79
b24e9fe
x-tyger added a commit to x-tyger/c2go that referenced this issue May 10, 2017
@x-tyger
Use os.Exit() for ReturnStmt in main(). Fixes elliotchance#79
a771f55
x-tyger added a commit to x-tyger/c2go that referenced this issue May 10, 2017
@x-tyger
Use os.Exit() for ReturnStmt in main(). Fixes elliotchance#79
b734de0
elliotchance added a commit that referenced this issue May 11, 2017
@elliotchance
Merge pull request #97 from x-tyger/fix79
24bcc05 
Use os.Exit() for ReturnStmt in main(). Fixes #79
@elliotchance elliotchance modified the milestones: Future Release, v0.10.x May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: small c: syntax d: bug
Projects
None yet
Milestone
v0.10.x
Development

No branches or pull requests
1 participant
@elliotchance