Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all "int" to "int32" for sizeof() compatibility. Fixes #683 #687

Merged
merged 8 commits into from
Apr 27, 2018

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented Apr 26, 2018

Fixes #683


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 26, 2018

Codecov Report

Merging #687 into master will decrease coverage by 0.3%.
The diff coverage is 85.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
- Coverage   82.18%   81.88%   -0.31%     
==========================================
  Files         164      164              
  Lines        8841     8875      +34     
==========================================
+ Hits         7266     7267       +1     
- Misses       1178     1207      +29     
- Partials      397      401       +4
Impacted Files Coverage Δ
darwin/ctype.go 55.1% <ø> (ø) ⬆️
program/function_definition.go 100% <ø> (ø) ⬆️
darwin/assert.go 0% <0%> (ø) ⬆️
transpiler/unary.go 74.55% <0%> (-1.34%) ⬇️
transpiler/enum.go 84.61% <100%> (-6.67%) ⬇️
noarch/noarch.go 50% <100%> (ø) ⬆️
transpiler/transpiler.go 86.85% <100%> (ø) ⬆️
types/cast.go 67.53% <100%> (ø) ⬆️
linux/math.go 100% <100%> (ø) ⬆️
noarch/string.go 100% <100%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6946d...9213854. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 19 of 29 files at r1, 12 of 12 files at r3, 2 of 2 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance changed the title Fix 683 sizeof int Refactor all "int" to "int32" for sizeof() compatibility. Fixes #683 Apr 27, 2018
@elliotchance elliotchance merged commit b8188d8 into elliotchance:master Apr 27, 2018
@kamphaus kamphaus deleted the fix-683-sizeof-int branch April 27, 2018 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants