non_null_attr: tolerate the lack of 'A' in the AST #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change regexp to tolerate 'A' being omitted. The C source code that creates this is: extern int blkid_probe_filter_superblocks_usage(blkid_probe pr, int flag, int usage) __ul_attribute__((nonnull)); Signed-off-by: Kevin Paul Herbert <kph@platinasystems.com>
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
==========================================
- Coverage 81.86% 81.84% -0.02%
==========================================
Files 164 164
Lines 8937 8940 +3
==========================================
+ Hits 7316 7317 +1
- Misses 1219 1221 +2
Partials 402 402
Continue to review full report at Codecov.
|
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
Perfect! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change regexp to tolerate 'A' being omitted.
The C source code that creates this is:
extern int blkid_probe_filter_superblocks_usage(blkid_probe pr, int flag, int usage)
ul_attribute((nonnull));
Signed-off-by: Kevin Paul Herbert kph@platinasystems.com
This change is