Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array initialization type. Fixes #699 #700

Merged

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented May 3, 2018

Fixes #699


This change is Reviewable

@codecov
Copy link

codecov bot commented May 3, 2018

Codecov Report

Merging #700 into master will increase coverage by 0.01%.
The diff coverage is 86.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
+ Coverage   81.94%   81.95%   +0.01%     
==========================================
  Files         164      164              
  Lines        8983     9016      +33     
==========================================
+ Hits         7361     7389      +28     
- Misses       1220     1223       +3     
- Partials      402      404       +2
Impacted Files Coverage Δ
transpiler/variables.go 83.53% <86.66%> (+0.27%) ⬆️
program/struct.go 57.77% <87.5%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b5721...f27ece8. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


tests/struct.c, line 354 at r1 (raw file):

const Point2* getPoint(int index) {
    return &(p2[index]);
}

There is no assertion in this code?


Comments from Reviewable

@kamphaus kamphaus force-pushed the fix-699-array-initialization-type branch from 6c86881 to f27ece8 Compare May 4, 2018 06:54
@kamphaus
Copy link
Contributor Author

kamphaus commented May 4, 2018

tests/struct.c, line 354 at r1 (raw file):

Previously, elliotchance (Elliot Chance) wrote…

There is no assertion in this code?

Sorry, I forgot the assert on another branch.
Added it now.


Comments from Reviewable

@elliotchance
Copy link
Owner

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 33840eb into elliotchance:master May 6, 2018
@kamphaus kamphaus deleted the fix-699-array-initialization-type branch May 6, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants