Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify atomic increment expressions. Fixes #717 #718

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented May 7, 2018

Fixes #717


This change is Reviewable

@kamphaus kamphaus force-pushed the fix-717-simplified-atomic-increment branch from 7368de6 to 5cb0dcc Compare May 7, 2018 19:09
@codecov
Copy link

codecov bot commented May 7, 2018

Codecov Report

Merging #718 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   82.03%   82.03%   +<.01%     
==========================================
  Files         164      164              
  Lines        9057     9058       +1     
==========================================
+ Hits         7430     7431       +1     
  Misses       1223     1223              
  Partials      404      404
Impacted Files Coverage Δ
transpiler/operators.go 78.05% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071d3ea...2311940. Read the comment docs.

@kamphaus kamphaus force-pushed the fix-717-simplified-atomic-increment branch from 5cb0dcc to 7cebf60 Compare May 7, 2018 19:11
@kamphaus kamphaus force-pushed the fix-717-simplified-atomic-increment branch from 7cebf60 to 2311940 Compare May 7, 2018 20:17
@elliotchance
Copy link
Owner

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 503b421 into elliotchance:master May 7, 2018
@kamphaus kamphaus deleted the fix-717-simplified-atomic-increment branch May 8, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants