Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast array to slice. Fixes #719 #720

Merged

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented May 7, 2018

Fixes #719


This change is Reviewable

@codecov
Copy link

codecov bot commented May 7, 2018

Codecov Report

Merging #720 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
+ Coverage   82.03%   82.04%   +<.01%     
==========================================
  Files         164      164              
  Lines        9057     9062       +5     
==========================================
+ Hits         7430     7435       +5     
  Misses       1223     1223              
  Partials      404      404
Impacted Files Coverage Δ
types/cast.go 69.89% <100%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071d3ea...cc04d20. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit b227b8f into elliotchance:master May 7, 2018
@kamphaus kamphaus deleted the fix-719-cast-array-2-slice branch May 8, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants