Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff HTML improvements #327

Open
Sternbach-Software opened this issue Nov 1, 2022 · 2 comments · May be fixed by #328
Open

Diff HTML improvements #327

Sternbach-Software opened this issue Nov 1, 2022 · 2 comments · May be fixed by #328

Comments

@Sternbach-Software
Copy link

Sternbach-Software commented Nov 1, 2022 •
edited
Loading

Because I have a lot of trees I am diffing, I compare them on my phone when I have a spare minute, so I'm primarily looking at the pages from a mobile browser (Chrome Android). How hard would it be to make the final output mobile friendly/responsive? That it uses bootstrap probably makes it easier (e.g. <table class="table-responsive">), though I'm not an experienced front-end dev.
@Sternbach-Software Sternbach-Software changed the title Make diff HTML mobile-friendly Diff HTML improvements Nov 2, 2022
@Sternbach-Software
Copy link
Author

It would also be nice to see the count of how many are only in left, right, both and equal, both and different.

@Sternbach-Software Sternbach-Software linked a pull request Nov 2, 2022 that will close this issue
Open
@Sternbach-Software
Copy link
Author

The table is not correct HTML: it is missing table headers,
using incorrect heading tags, and
missing thead and tbody. It also uses several deprecated tags, such as scope="row".

Sternbach-Software added a commit to Sternbach-Software/gedcom that referenced this issue Nov 6, 2022
@Sternbach-Software
1. Add ancestry-source-matching flag to toggle whether to perform tha…
d2dc486 
…t check

2. Make table responsive by setting viewport to device width and adding table class `table-responsive` (elliotchance#327)
3. Add GEDCOM paths to DiffPage
4. Add how many are only in the right, left, and both GEDCOMs (elliotchance#327)
5. Fix error in node_diff.go documentation
6. Optimize Ancestry source matching and test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Responsive diff page html Sternbach-Software/gedcom
1 participant
@Sternbach-Software