Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified cvts and added xreg support #69

Merged
merged 12 commits into from
Jan 23, 2017
Merged

Simplified cvts and added xreg support #69

merged 12 commits into from
Jan 23, 2017

Conversation

ganesh-krishnan
Copy link
Contributor

  • Added function and tests to generate test train splits
  • Created function to subset time series using indices
  • Simplified cvts to use tsPartitions

Using tsPartitions (and saving the train/test splits) allows passing an xreg parameter

@ganesh-krishnan
Copy link
Contributor Author

  • Added support for xreg
    • Will transparently check if FUN accepts xreg
    • No check for FCFUN because forecast() only accepts ... as an argument
  • Added tests for xreg

@ganesh-krishnan ganesh-krishnan changed the title Simplified cvts and prepared for xreg Simplified cvts and added xreg support Jan 22, 2017
@dashaub
Copy link
Collaborator

dashaub commented Jan 22, 2017

Since this removes the "purrr" imports from NAMESPACE, can we remove it from the DESCRIPTION file too?

@ganesh-krishnan
Copy link
Contributor Author

@dashaub removed purrr from DESCRPTION file.

@dashaub dashaub merged commit cbb1f04 into ellisp:master Jan 23, 2017
@ganesh-krishnan ganesh-krishnan mentioned this pull request Jan 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganesh-krishnan @dashaub