Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stock_time_series.jl #64

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

snovum
Copy link
Contributor

@snovum snovum commented Aug 29, 2023

According to the Alpha Vantage Documentation time_series_intraday_extended queries have now been folded into time_series_intraday queries via an added optional month parameter. I tried to incorporate the optional parameters month, extended_hours, and adjusted by making the following changes. 1) Adding the above parameters to the time_series_intraday function and defaulting the boolean parameters extended_hours and adjusted to true as per the API documentation. 2) Adding an argcheck for the non boolean month parameter to ensure that months are entered in the required (YYYY-MM) format starting from 2000-01 which is when data is first available. 3) Adding the new parameters to the paramsdictionary. No other alterations were made to the time_series_intraday function. I removed the time_series_intraday_extended function as it appears to have been deprecated. It no longer appears in the Alpha Vantage API documentation and did not appear to work when I tested it. Thanks for reviewing the matter.

According to the Alpha Vantage Documentation `time_series_intraday_extended` queries have now been folded into `time_series_intraday` queries via an added optional month parameter.  I tried to incorporate the optional parameters `month`, `extended_hours`, and `adjusted` by making the following changes.  1)  Adding the above parameters to the `time_series_intraday` function and defaulting the boolean parameters `extended_hours` and `adjusted` to `true` as per the API documentation.   2)  Adding an argcheck for the non boolean `month` parameter to ensure that months are entered in the required (YYYY-MM) format starting from 2000-01 which is when data is first available.  3) Adding the new parameters to the `params`dictionary.  No other alterations were made to the `time_series_intraday` function.    I  removed the `time_series_intraday_extended` function as it appears to have been deprecated. It no longer appears in the Alpha Vantage API documentation and did not appear to work when I tested it.   Thanks for reviewing the matter.
@ellisvalentiner ellisvalentiner merged commit a08ddf0 into ellisvalentiner:master Aug 31, 2023
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants