Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement date and time picker #39

Merged
merged 5 commits into from
Oct 11, 2019
Merged

Implement date and time picker #39

merged 5 commits into from
Oct 11, 2019

Conversation

ellykits
Copy link
Owner

@ellykits ellykits commented Oct 9, 2019

Closes #10 and #9
On the main form time picker and date picker views are differentiated by these icons respectively

ic_schedule
ic_today

As shown in this sample screenshot
Screenshot_1570808579

Date picker
Screenshot_1570808582

Time picker
Screenshot_1570808589

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #39 into master will increase coverage by 1.11%.
The diff coverage is 79.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
+ Coverage     74.24%   75.36%   +1.11%     
- Complexity      192      215      +23     
============================================
  Files            24       26       +2     
  Lines           532      617      +85     
  Branches         93      105      +12     
============================================
+ Hits            395      465      +70     
- Misses           53       58       +5     
- Partials         84       94      +10
Impacted Files Coverage Δ Complexity Δ
...java/com/nerdstone/neatformcore/utils/Constants.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...ain/java/com/nerdstone/neatformcore/utils/Utils.kt 46.15% <0%> (-13.85%) 7 <0> (ø)
...atformcore/views/builders/RadioGroupViewBuilder.kt 67.34% <0%> (-2.87%) 16 <0> (ø)
...java/com/nerdstone/neatformcore/utils/ViewUtils.kt 81.39% <100%> (+0.9%) 19 <0> (+1) ⬆️
...neatformcore/views/builders/EditTextViewBuilder.kt 64.51% <66.66%> (+3.91%) 10 <0> (ø) ⬇️
...tformcore/views/widgets/DateTimePickerNFormView.kt 76.92% <76.92%> (ø) 6 <6> (?)
...rmcore/views/builders/DateTimePickerViewBuilder.kt 86.56% <86.56%> (ø) 16 <16> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 468e66e...ed1824e. Read the comment docs.

@ellykits ellykits merged commit 39a8a5f into master Oct 11, 2019
@ellykits ellykits deleted the issue-9-date-time-picker branch October 11, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a time picker
1 participant