This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
missing millis in "toISO8601" #30 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witoldsz
commented
Apr 23, 2017
| @@ -235,7 +235,7 @@ toFromISO8601 = | |||
| [ test "toISO8601 of epoch is correct" <| | |||
| \() -> | |||
| toISO8601 epoch | |||
| |> Expect.equal "1970-01-01T00:00:00Z" | |||
| |> Expect.equal "1970-01-01T00:00:00.000Z" | |||
There was a problem hiding this comment.
This is how date.toISOString() works in JS, so I decided not to cut the millis when zero.
witoldsz
force-pushed
the
iso8601_millis
branch
from
45254ed
to
cc60419
Compare
|
Thanks for the detailed testing! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.