Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm installer: Download elm package without deprecated libraries. #2307

Closed
wants to merge 3 commits into from

Conversation

mather
Copy link

@mather mather commented Aug 18, 2023

Quick Summary:
request is deprecated, and vulnerabilities have been reported in its dependency libraries.
I replaced download feature using following libraries:

Ref: 41ec49e

Thought:
axios also depends on the same libraries (follow-redirects, proxy-from-env), but there is no need to use Promise-based features.
To improve maintainability, I believe that we should adopt libraries with simple enough functions to meet our needs,rather than relying on a library with many additional functions.

@github-actions
Copy link

Thanks for suggesting these code changes. To set expectations:

  • Pull requests are reviewed in batches, so it can take some time to get a response.
  • Smaller pull requests are easier to review. To fix nine typos, nine specific issues will always go faster than one big one. Learn why here.
  • Reviewers may not know as much as you about certain situations, so add links to supporting evidence for important claims, especially regarding standards for CSS, HTTP, URI, etc.

Finally, please be patient with the core team. They are trying their best with limited resources.

@mather
Copy link
Author

mather commented Aug 19, 2023

I want to review the behavior of proxy and organize the commits, so I close PR.

@mather mather closed this Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant