Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML5 inputmode attribute, possible properties #75

Closed
wants to merge 2 commits into from

Conversation

@process-bot
Copy link

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@tolgap
Copy link

tolgap commented Aug 26, 2016

@kevinSuttle you have defined the function max : String -> Attribute msg 11 times and function form twice. Copy paste mistake? :)

@kevinSuttle
Copy link
Author

Gah. Seems like it. Will fix!

@kevinSuttle
Copy link
Author

@tolgap I think I fixed it?

@kevinSuttle
Copy link
Author

@tolgap bump

@tolgap
Copy link

tolgap commented Aug 29, 2016

@kevinSuttle I'm not on the collaborator list. I was just looking through the open PRs and I noticed yours and looked through it.

But yes your previous error seems fixed.

@kevinSuttle
Copy link
Author

Ah ok cool. Thanks for taking a look!

@evancz
Copy link
Member

evancz commented Aug 29, 2016

Seems reasonable. I added this recommendation to #53 so it can be released at a nice time with a bunch of other stuff. Like @process-bot says, we try to batch work on the various Elm projects, so it is fine to "bump" work like this, but the process will still work the same way.

@evancz evancz closed this Aug 29, 2016
@kevinSuttle
Copy link
Author

Sounds good to me. Thanks Evan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants