Make model/dispatch available to getWindow in Binding.subModelWin #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeeren
commented
Sep 25, 2019
Yep, look perfect :)
I hate when that happens :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
@bender2k14 does this PR look good to you from a boxing/unboxing/type perspective?
By the way, the diff "boundaries" are a bit weird around the new
Bindingoverloads. I have simply changed thegetWindowsignature for each of the threesubModelWinoverloads (with slight edits to the docs), and made copies of each of them with the old signature, delegating to the new. The diff makes it seem like I have made extensive edits to the docs because it has identified the "wrong boundaries", so to speak.