-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive cached binding #183
Conversation
Thanks a lot! There's a lot to take in here, but I can't see anything obviously wrong. Could you also just verify that all relevant samples still work? If they do, and all tests still pass, then I think it's good to go (after resolving the other conversations). |
I tried to separate conceptual changes by commit. Reviewing one commit at a time could help.
Will do. |
01d5a24
to
38bd805
Compare
For good measure, I tried all the samples. Everything seemed to work. |
Great, thanks! |
38bd805
to
7823e96
Compare
Looks good to me. Merge when you're ready :) |
Fixes #181
Creates a recursive binding type called
CachedBinding<'model, 'msg>
. The caching in theOneWayLazy
andSubModelSelectedItem
cases are removed and now use this cached binding instead.All the tests pass, and there is an existing test for
OneWayLazy
that ensures that caching is working.I left one comment in the code to make sure we have a conversation about it. I will create a comment in this PR on that line next.