Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memoize mapper in oneWayMap #44

Closed
wants to merge 1 commit into from
Closed

memoize mapper in oneWayMap #44

wants to merge 1 commit into from

Conversation

cmeeren
Copy link
Member

@cmeeren cmeeren commented Aug 4, 2018

Fixes #43

Briefly tested, seems to work fine. mapper now remembers the return value of its previous argument. (I chose to limit it to a single value since that fixes #43 and avoids memory usage concerns from remembering an unlimited number of return values.)

@cmeeren cmeeren mentioned this pull request Aug 25, 2018
7 tasks
@cmeeren
Copy link
Member Author

cmeeren commented Sep 1, 2018

Closed by #48

@cmeeren cmeeren closed this Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance suggestion: Make the mapper in oneWayMap bindings lazy or memoized
1 participant