Allow non F# union-types to be used as messages #21
Conversation
|
You are the first to forgo F# unions for messages, didn't seem a likely scenario, but here we are. I'd usually fire up one of the samples to test the debugger, but if you can think of some integration tests that would be cool. Otherwise, does this PR as it is completely solve the issue for you? Also, do you want to backport it to 2.x branch (the master branch is for 3.x release, which will not release until elmish 3.x is out)? |
It seems like it does. I don't like how it depends on fable internals but yeah I need to verify in the complete application (wrote a test and verified this fixes it as of now)
Having a v2 release with this would be very much appreciated, what do I need to do? Send the same change to v2 branch? Cherry-pick? |
|
Send the PR for v2 branch, the commit is up to you. |
|
Regarding elmish v3. While fixing various issues around the debugger I think it might make sense to introduce a |
|
There's a discussion @ elmish/elmish#162, I will consider addressing this use case as well. |
| match FSharpValue.GetUnionFields(x, typeof<'a>) with | ||
| | case, _ -> case.Name | ||
| let t = typeof<'a> | ||
| if (isNull t?cases) |
There was a problem hiding this comment.
Instead of relying in the internal JS representation of F# unions by Fable (which may change in the future), you can just use FSharpType.IsUnion: https://github.com/fable-compiler/Fable/blob/e2ce9884390d95d223044e666c7c251c7392b428/tests/Main/ReflectionTests.fs#L385
Latest Fable.Core also includes some reflection helpers: https://github.com/fable-compiler/Fable/blob/e2ce9884390d95d223044e666c7c251c7392b428/src/Fable.Core/Fable.Core.Util.fs#L26-L32
fixes #20
Actually, I think this should have created problems for anyone not using F#-unions. I think we should add a test for this case.
Are there already tests in this library?