Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes #2

Merged
merged 2 commits into from
Apr 23, 2020
Merged

small changes #2

merged 2 commits into from
Apr 23, 2020

Conversation

E-G-C
Copy link
Contributor

@E-G-C E-G-C commented Apr 23, 2020

-mux_all defaults to video file if not new video is created
-download return video path after download,

-mux_all defaults to video file if not new video file is created 
-download returns the path to the downloaded file
@elmoiv elmoiv merged commit 4c1a1b7 into elmoiv:master Apr 23, 2020
@elmoiv
Copy link
Owner

elmoiv commented Apr 23, 2020

Thanks for your contribution!

I am planning now to convert videos without audio via ffmpeg too.
Problem is those videos have a codec that prevents you from sharing them through some applications and platforms.

@elmoiv
Copy link
Owner

elmoiv commented Apr 23, 2020

Note that you should use the global formatting not Python 3.6+ formatting to make the project available for Python 3.x users.

Always use "{}".format(s) instead of f"{s}".
I already updated your pull request.

@elmoiv elmoiv added the enhancement New feature or request label Apr 23, 2020
@E-G-C
Copy link
Contributor Author

E-G-C commented Apr 23, 2020

guilty 😔...haven't targeted anything lower than 3.6 in a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants