Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix detecting if gceClient should connect via public or private IPs #109

Merged
merged 2 commits into from
Jun 1, 2020
Merged

fix detecting if gceClient should connect via public or private IPs #109

merged 2 commits into from
Jun 1, 2020

Conversation

justnoise
Copy link
Contributor

No description provided.

@justnoise justnoise requested a review from ldx June 1, 2020 18:01
ldx
ldx approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@ldx ldx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you rebase on current master, the build should also pass.

@justnoise justnoise merged commit d6e7f3c into master Jun 1, 2020
@ldx ldx mentioned this pull request Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldx ldx ldx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justnoise @ldx