Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! I'm using your library via a somewhat involved chain of dependencies, and I've been running into a memory leak. I debugged it using the node's heap inspector and I found that the
queue
object here continuously grows in size because its keys never get deleted. The object looks like{1: null, 2: null, 3: null, ...}
.The fix is pretty easy -- just use
delete
to remove the key from the object in addition to the value.The main change is the delete thing ^. Some other files seem to have changed when I made the change above and ran
test
and I'm not sure why. I'm kind of a noob to the js ecosystem, so please tell me if I should revert some of those changes.