-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DataPack encode and decode rpc message #150
Conversation
79724cf
to
94eba7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just need to sort out these first few lines in API.md that are modified for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just minor changes on API.md needed.
Are there any other questions with the API documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
A DataPack API is added to implement the encoding and decoding logic of messages. The default encode and decode logic is still JSON, and when the user wants to extend, pass in the user-implemented DataPack class instance when instantiating on the server or client.