Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not scrolling elements into view #26

Closed
stormfar opened this issue Jan 22, 2018 · 6 comments
Closed

Not scrolling elements into view #26

stormfar opened this issue Jan 22, 2018 · 6 comments

Comments

@stormfar
Copy link

reactour is not auto-scrolling to elements outside the viewport. My header and sidebar are fixed elements, and the main element contains the components, including those not being scrolled to.

screen recording 2018-01-22 at 04 25 pm

My app has the following markup:

<div class="app">
  <header class="app-header"></header> <!-- fixed el -->
  <div class="app-body">
    <div class="sidebar"></div> <!-- fixed el -->
    <main></main>
  </div>
</div>

Any idea what could be preventing the scrolling?

@elrumordelaluz
Copy link
Owner

Hi @5tormTrooper,
First of all, thanks to reach out and fill this issue.
I am trying to reproduce it but everything works well in the example I did.

demo

Could you please give an eye to the code of this example?

Then we can analyse which is the difference with your use case, maybe making changes on the sandbox.

@elrumordelaluz
Copy link
Owner

elrumordelaluz commented Jan 26, 2018

@5tormTrooper please let me know if you solved the Issue so we can close it. Otherwise, I'll ask you more information to reproduce the behavior you showed.

Will close the Issue, feel free to re-open in case you need.

@stormfar
Copy link
Author

stormfar commented Mar 9, 2018

@elrumordelaluz thanks for taking the time to demo this. After comparing the two, I released that there was a stray overflow rule on the app-body. After removing it the scrolling works fine. So it was a problem with my app and not the package.

Sorry for the delayed response, other issues got promoted to top priority...

Thanks again for looking into it!

@elrumordelaluz
Copy link
Owner

elrumordelaluz commented Mar 9, 2018 via email

@nvoisin
Copy link

nvoisin commented Sep 12, 2019

Hi @5tormTrooper
I know this thread is pretty old but I'm having the exact same problem ! Any idea what would cause the scroll not to work ? I've tried removing every overflow css setting and nothing seems to work..
If you have any ideas as to what blocks the scroll, thanks for letting me know

@nvoisin
Copy link

nvoisin commented Sep 12, 2019

Found another example where it doesn't seem to work :
https://stackoverflow.com/questions/57417050/getting-reactour-to-scroll-within-coreui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants