Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#11 #12

Merged
merged 14 commits into from
Mar 25, 2019
Merged

Feature/#11 #12

merged 14 commits into from
Mar 25, 2019

Conversation

els0r
Copy link
Owner

@els0r els0r commented Mar 7, 2019 •
edited
Loading

This feature implements a REST API for goProbe. In fact, they are so big that it warrants putting them in a major version bump.

Changes are breaking, since it removes the - admittedly clumsy - command handling previously done via the goProbe socket.

Note: the PR is big due to simultaneous renaming of most constants and variables in order to conform to golint.

@els0r els0r added the feature New feature or request label Mar 7, 2019
@els0r els0r self-assigned this Mar 7, 2019
@els0r els0r requested a review from fako1024 March 7, 2019 14:38
els0r added a commit that referenced this pull request Mar 14, 2019
@els0r
feature/#12: goQuery: separate query interface from cli tool. Impleme…
c3977e3 
…nt CLI using cobra framework
fako1024
fako1024 requested changes Mar 16, 2019
View reviewed changes
Copy link
Collaborator

@fako1024 fako1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! I found a few things to maybe think about, will now go ahead and try out the branch...

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cmd/goConvert/goConvert.go Outdated Show resolved Hide resolved
cmd/goProbe/config/config.go Outdated Show resolved Hide resolved
pkg/api/v1/get_routes.go Outdated Show resolved Hide resolved
pkg/api/v1/post_routes.go Outdated Show resolved Hide resolved
pkg/api/v1/post_routes.go Show resolved Hide resolved
pkg/api/v1/post_routes.go Show resolved Hide resolved
pkg/goDB/bigendian/readint_asm.go Show resolved Hide resolved
@els0r els0r mentioned this pull request Mar 23, 2019
Closed
@els0r els0r requested a review from fako1024 March 23, 2019 21:09
fako1024
fako1024 approved these changes Mar 24, 2019
View reviewed changes
Copy link
Collaborator

@fako1024 fako1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thx for the amendments!

@els0r els0r merged commit 7ea4d2f into develop Mar 25, 2019
@els0r els0r deleted the feature/#11 branch March 25, 2019 20:22
els0r added a commit that referenced this pull request Mar 26, 2019
@els0r
Feature/#12: documentation update
7cd097a
els0r added a commit that referenced this pull request Mar 26, 2019
@els0r
Feature/#12: correct query example
d561b50
els0r added a commit that referenced this pull request Mar 26, 2019
@els0r
Feature/#12: correct query example
d4f2e3d
els0r added a commit that referenced this pull request Apr 4, 2019
@els0r
feature/#12: make the linter happy. Bundle linting, testing and insta…
6042b1f 
…lling in a generate command
els0r pushed a commit that referenced this pull request May 10, 2019
Feature/#12: PR review feedback
a24a8ee
els0r added a commit that referenced this pull request May 10, 2019
@els0r
Merge pull request #15 from els0r/feature/#12
616d3f6 
Feature/#12: separation of CLI tool and query API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fako1024 fako1024 fako1024 approved these changes

Assignees

@els0r els0r

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@els0r @fako1024