Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlock + multiple trigger support #3720

Merged
merged 4 commits into from
Feb 20, 2023
Merged

Fix deadlock + multiple trigger support #3720

merged 4 commits into from
Feb 20, 2023

Conversation

sfmskywalker
Copy link
Member

This PR fixes two issues:

  1. Deadlock: the workflow runtime would always deadlock when triggering workflows (because of ResumeDispatchWorkflowActivityHandler).
  2. Having multiple triggers on a flowchart would not schedule the triggered activity, but the first activity always.

Fixes #3713

@sfmskywalker sfmskywalker merged commit d2d7f23 into v3 Feb 20, 2023
@sfmskywalker sfmskywalker deleted the v3-workflow-runtime-improvements branch February 20, 2023 11:05
@sfmskywalker sfmskywalker mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfmskywalker