Added ability to externalize MongoClient creation #4262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed so the caller program can implement a system to have a single MongoClient for the entire application. Actually the driver already uses an internal cache to have only one MongoClient but with this commit we can let the user decide how to create the MongoClient.
alkampfergit
force-pushed
the
feature/mongodb_externalize_mongoclient_creation
branch
from
3d1bf22
to
4ad158a
Compare
sfmskywalker
approved these changes
Jul 27, 2023
alkampfergit
deleted the
feature/mongodb_externalize_mongoclient_creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best practice for usage of MongoClient is creating a single instance for the entire process. (or a single instance for each different connection string).
Actual code create a new MongoClient and uses a local cache to limit the number of client, but with this commit we allow the caller to redefine the function to create MongoClient and use an external cache (or use decorators, etc).