Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C# expression support #4594

Merged
merged 9 commits into from
Nov 3, 2023
Merged

Add C# expression support #4594

merged 9 commits into from
Nov 3, 2023

Conversation

sfmskywalker
Copy link
Member

@sfmskywalker sfmskywalker commented Nov 2, 2023 •
edited by github-actions bot
Loading

This PR adds C# as a syntax option for activity input expressions.

=== auto-pr-body ===

Summary:

  • Removed the JavaScript Integration feature and related code from ModuleExtensions.cs
  • Updated existing code in MagicWorkflow.cs to use GetInput instead of GetWorkflowInput

Suggested Refactoring:

  • Refactor MagicWorkflow.cs to improve readability and reduce code complexity
  • Review any dependent code that may have been affected by the removal of the JavaScript integration feature in ModuleExtensions.cs

@sfmskywalker sfmskywalker added elsa 3 This issue is specific to Elsa 3 enhancement New feature or request labels Nov 2, 2023
@sfmskywalker sfmskywalker merged commit 5d1a1aa into v3 Nov 3, 2023
2 checks passed
@sfmskywalker sfmskywalker deleted the csharp-expressions branch November 3, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
elsa 3 This issue is specific to Elsa 3 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfmskywalker