Add NUKE build support #4815
Merged
Add NUKE build support #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
nuke
branch
6 times, most recently
from
ce80f5e
to
f29ce17
Compare
sfmskywalker
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to add minimal NUKE build support. You're using some advanced GitHub Actions definitions, so it's not that easy to shift logic from them to the C# build. As first iteration I'm suggesting to move the build part to calling the NUKE infrastructure and generating the PR template that will be run against any PRs for this repo.
I removed the duplicate projects from the solution file as NUKE wasn't too happy about them. Also let Visual Studio open the file and update project GUIDs and fixed projects locations. After solution was saved Rider no longer complained about project loading problems either.