Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the Timer Interval default value to match DefaultValue #4926

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

mohdali
Copy link
Member

@mohdali mohdali commented Feb 10, 2024

Should fix #4818

@mohdali mohdali changed the title Set the default value for Interval to match DefaultValue (should fix #4818) Set the Timer Interval default value to match DefaultValue Feb 10, 2024
@sfmskywalker sfmskywalker merged commit f85615f into main Feb 17, 2024
2 checks passed
@sfmskywalker sfmskywalker deleted the timer-fix branch February 17, 2024 08:20
@sfmskywalker
Copy link
Member

Thanks @mohdali !

@NightWuYo
Copy link
Contributor

Thanks @mohdali , may I know why this would fix #4818 ? I have set the interval for the timer in the Studio, seems the default value will not be used.

@mohdali
Copy link
Member Author

mohdali commented Feb 17, 2024

Thanks @mohdali , may I know why this would fix #4818 ? I have set the interval for the timer in the Studio, seems the default value will not be used.

The default value of null will cause Quartz scheduler to fail to start. Currently Elsa studio upates the value on change only. So even if you manually edit the value but kept it as 00:01:00 it will still be treated as null.

Otherwise, Quartz scheduling should work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quartz Scheduler is not working in v3
3 participants