-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add created date time to filter #4932
feature: Add created date time to filter #4932
Conversation
b756754
to
dc92c5e
Compare
dc92c5e
to
349bb51
Compare
Hello @sfmskywalker, do you have any questions about this PR? |
Hi @bbenameur , not yet - I just haven't found the time to go over it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good, thanks!
Hi @bbenameur , just a quick heads up: we are about to merge this PR that changes the API a bit. In summary, it offers more options to filter by date ranges, including CreatedAt (which you added via your PR), UpdatedAt and FinishedAt, on top of a few more filters. This will change the API in the following way (example):
Notice that for the date ranges, we now have to provide a TimestampFilters parameter when using GET requests. Please let me know if you have any questions or concerns about this upcoming change. Thanks again for your contributions! |
Hello, @sfmskywalker ia agree is the best and flexible way, thanks. |
Issue: #4937
Need:
Current:
At the endpoint elsa/api/workflow-instances currently return all workflow instances even we have millions of instances !!
Target:
Add two properties to filters, FromCreatedAt and ToCreatedAt to help us to get instances between 2 date times.