Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes from version 2.4.0-preview.493 to 2.5.0 #28

Open
oacostam opened this issue Mar 4, 2022 · 3 comments
Open

Breaking changes from version 2.4.0-preview.493 to 2.5.0 #28

oacostam opened this issue Mar 4, 2022 · 3 comments

Comments

@oacostam
Copy link

oacostam commented Mar 4, 2022

Hello.
Current elsa-guides uses version 2.4.0-preview.493 of Elsa libraries. When I try to upgrade it to 2.5.0 I got an error on DocumentManagement.Workflows.Handlers.StartDocumentWorkflows, line 31. Current version contains:

// Get all workflow blueprints tagged with the received document type ID.
            var workflowBlueprints = await _workflowRegistry.FindManyAsync(x => x.IsPublished && x.Tag == documentTypeId, cancellationToken).ToList();

After the upgrade, I got the following compiler error:
"Error CS1061 'IWorkflowRegistry' does not contain a definition for 'FindManyAsync' and no accessible extension method 'FindManyAsync' accepting a first argument of type 'IWorkflowRegistry' could be found (are you missing a using directive or an assembly reference?)"

What could be a good replacement for method IWorkflowRegistry.FindManyAsync in version 2.5.0?

Kind regards.

@sfmskywalker
Copy link
Member

Hi @oacostam,

Sorry about that. There's currently no replacement for that scenario, which is an omission on my part. I will add a method that let's you find all workflow blueprints by tag. The method will be called FindManyByTagAsync.

@sfmskywalker
Copy link
Member

sfmskywalker commented Mar 14, 2022

I pushed an update that adds the aforementioned method. I'll update the sample code once 2.6 is released (which will contain this new method).

@oacostam
Copy link
Author

oacostam commented Mar 14, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants