Add secret and namespace completion (requires kubectl 1.26) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this to work, you will need kubectl 1.26 and a shim that you can create with the following command: cat <<'EOF' >~/bin/kubectl_complete-view_secret && chmod u+x ~/bin/kubectl_complete-view_secret kubectl view-secret __complete "$@" EOF See: kubernetes/kubernetes#105867
elsesiy
reviewed
Mar 6, 2023
| @@ -191,3 +193,167 @@ func ProcessSecret(outWriter, errWriter io.Writer, secret map[string]interface{} | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func getNamespaces(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { | |||
| return nil, cobra.ShellCompDirectiveNoFileComp | ||
| } | ||
|
|
||
| func getSecrets(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { |
There was a problem hiding this comment.
args is unsed, can we ignore _ it?
|
I built your version and tested, but it doesn't seem to pick up the script or work. I am using 1.27.X |
|
I took a slightly different approach in #47 allowing you to interactively select the secret (not the namespace yet). I might add proper completion support at some point after I receive some feedback on the current ergonomics |
|
Hi, the addition to interactively select the secret is really great. However, one of our namespaces has more than 3000 secrets. Scrolling through them in a list isn't working. Tab completion would really be welcome in this case. Hopefully it will still be added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to work, you will need kubectl 1.26 and a shim that you can create with the following command:
See: kubernetes/kubernetes#105867
Closes #3