ACF processing fixes and test features #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make acf a full fledged iOS acf-detect.app
+ XCODE_BUNDLE_IDENTIFIER for use with ios-deploy
+ add plist.in to support file sharing (viewable output files)
+ add command line option for dumping pyramids as flat images for analysis
+ is now compatible with ios-deploy
+ add argv preprocessing via regex_replace of regex(“HOME”) w/ getenv(HOME) — this allows passing generic command line arguments from the command line for use with ios-deploy, since we don’t know the path of the installed executable and associated data (this is similar to the gauze generator expressions used for cross platform unit tests)
* add acf-detect test/tune features
+ add randomShapes() function to draw some random patterns w/ various colors (lines, ellipses, rectangles) — this was used initially to support gpu/cpu pyramid testing on mobile devices
+ support internal pyramid drawing for analysis
+ unify include style
+ make VideoSource respect “—random” command line option (a separate class can be added (possibly with the ability to insert random faces))
* clip gradient values to upper/lower bounds of the lookup table in gradientMex:gradMag() — this replaces a more complex function that was most likely aiming to do the same thing but was actually incorrectly modifying the orientation bins
* fix gradhist shader multi-channel orientation histogramming binning interpolation logic (this was correct but missed an edge case where orientations of 1.0 were counted in the bin==1 instead of bin==0
* add dodecagon test image to the test files
* formatting
* add CMakeLists.txt code block describing HUNTER_KEEP_PACKAGES_SOURCES option — somewhat pedantic, but a useful build configuration for development tasks
* workaround for OpenCV protobuf compiler crash w/ ios build for local builds — this may be limited to xcode 9.1 but should be fine since the opencv_dnn module isn’t used by acf anyway
ruslo
reviewed
Apr 3, 2018
cmake/Hunter/config.cmake
Outdated
| @@ -0,0 +1,10 @@ | |||
| string(COMPARE EQUAL "${CMAKE_OSX_SYSROOT}" "iphoneos" _is_ios) | |||
| if(_is_ios) | |||
There was a problem hiding this comment.
if(IOS) should work fine here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make acf a full fledged iOS acf-detect.app
add acf-detect test/tune features
clip gradient values to upper/lower bounds of the lookup table in gradientMex:gradMag() — this replaces a more complex function that was most likely aiming to do the same thing but was actually incorrectly modifying the orientation bins
fix gradhist shader multi-channel orientation histogramming binning interpolation logic (this was correct but missed an edge case where orientations of 1.0 were counted in the bin==1 instead of bin==0
add dodecagon test image to the test files
formatting
add CMakeLists.txt code block describing HUNTER_KEEP_PACKAGES_SOURCES option — somewhat pedantic, but a useful build configuration for development tasks
workaround for OpenCV protobuf compiler crash w/ ios build for local builds — this may be limited to xcode 9.1 but should be fine since the opencv_dnn module isn’t used by acf anyway