Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Support for PA series #14

Merged
merged 2 commits into from
Nov 26, 2022
Merged

Initial Support for PA series #14

merged 2 commits into from
Nov 26, 2022

Conversation

pp81381
Copy link
Contributor

@pp81381 pp81381 commented Nov 26, 2022

First cut of support for PA series

So far, I've followed the pattern of the SA series and supported the PA series to about the same extent as the SA series is supported. All of the known command codes can be sent and received by the Client but the State class can only be used for power and mute so far. (Worth noting that it is necessary to call update() on the State object before power or mute will work for the SA or PA series.)

I'm working on further changes to add support for decoding more of the messages and adapt the State class for it. Will write some ideas in the Issue that I posted.

Copy link
Owner

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, do you want me to merge this now?

@pp81381
Copy link
Contributor Author

pp81381 commented Nov 26, 2022

I'd say yes. I have more work in the pipe but it doesn't affect this piece and I'm not ready to commit it yet so I'll raise a new PR for that.

@elupus elupus merged commit 37015e1 into elupus:master Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants