-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration and output changes #184
base: main
Are you sure you want to change the base?
Conversation
CMDLINE.md
Outdated
@@ -154,6 +154,8 @@ Commands: | |||
Options: | |||
--version Show version number [boolean] | |||
-v, --verbose Verbose mode [boolean] | |||
-n, --network Network to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For customers I would like to go with main
dv3
(because I want to call this a dev network - for developers to build on top of the content fabric) then I think either test
or tv4
for the test network and then local
for the local qfab (127.0.0.1).
It is important to finalize these names before we expose them officially:
In summary this is what I'm thinking:
main
- the main Content Fabric networkdv3
- Content Fabric dev networktv4
- Internal Content Fabric test networklocal
- Local development environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values are taken from Config.js
, e.g.:
const networks = {
main: "https://main.net955305.contentfabric.io",
demo: "https://demov3.net955210.contentfabric.io",
demov3: "https://demov3.net955210.contentfabric.io",
test: "https://test.net955205.contentfabric.io/config",
dev: "http://localhost:8008/config?qspace=dev&self",
};
So I would need to rename all of these to conform. Easy to do, but don't want tomato this change without checking.
Two changes:
--output
option allows getting any YAML data to be sent to a file specified at the CLI forEluvioCli.js
andEluvioLiveCli.js
--network
option that allows specifying the network that the commands run on. Defaults tomain
. Removes the need to make changes tosrc/Config.js