-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit:del-var would be useful #1265
Comments
Can I work on this one? I think I can implement this. |
@supreetsingh10: No need to ask permission. In general, for open source projects like Elvish it is sufficient to simply say "I'm going to work on this issue." And a lot of the time even that isn't needed. Having said that, I think you are underestimating the difficulty of this problem relative to your knowledge of Elvish and Go. Take a look at any of my pending pull requests such as PR #1270. All of those address an issue that is no more complicated than this issue. If you understand those changes you might be successful at implementing this feature. |
@supreetsingh10: Take a look at PR #1221 which has been abandoned by its author. Given the feedback in that PR you should be able to create a new PR that correctly fixes the problem. |
Thank you for the guidance. That is true, I need to get more skilled before I tackle these problems. Thank you Mr. @krader1961. |
Mr. @krader1961 I think I have got this problem figured out. I have written some code, it is not enough to be pushed, so I am posting my doubts here, you can reply to them when you have time. Since I am working on |
@supreetsingh10: Without doing my own investigation of the relevant code I have no idea what the answers are to your questions. This is something you will need to figure out on your own. It is why I have been gently suggesting you try solving easier issues for your initial set of changes. A change that affects the behavior of the |
Mr. @krader1961, your feedbacks and guidance are very important to me, I have been following everything you said, I am also learning Elvish from the guide available. You have asked me to work on simpler things, it is just I have a habit of tinkering with things, that is why I started working on this. Anyway, I will drop this thing for a while and look for a simpler issue. I think elvish is really cool, I just want to learn as much as I can from this project and experienced people who have made this. I am sorry if you felt that I did not listen to you, you helped me throughout the file module, I am very grateful for that. |
I think it would be useful go have an
edit:del-var
, analogous toedit:add-var
, to remove a variable from the interactive scope.For me, a specific use case would be to undefine aliases in the current session. At the moment this can be done by redefining the alias variable to a function that calls the corresponding external command (see https://github.com/zzamboni/elvish-modules/blob/master/alias.elv#L95), but it seems just being able to remove the variable would be cleaner.
The text was updated successfully, but these errors were encountered: