Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more info for an invalid doc link #1752

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

krader1961
Copy link
Contributor

Make it more obvious why a documentation reference link is invalid when the URL path incorrectly includes a trailing slash. This would have saved me an hour of debugging when I was working on a change that included a reference like this one:

[`edit:histlist:start`](../ref/edit.html/#edit:histlist:start)

Fixes #1749

Make it more obvious why a documentation reference link is invalid when
the URL path incorrectly includes a trailing slash. This would have
saved me an hour of debugging when I was working on a change that
included a reference like this one:

    [`edit:histlist:start`](../ref/edit.html/#edit:histlist:start)

Fixes elves#1749
@xiaq xiaq changed the base branch from master to check-rellinks January 22, 2024 15:18
@xiaq
Copy link
Member

xiaq commented Jan 22, 2024

This check should be generalized to check for all bogus slashes as well as missing slashes. I have posted a bit more explanation in #1749 (comment).

@xiaq xiaq merged commit 3f4fbff into elves:check-rellinks Jan 22, 2024
13 of 16 checks passed
@krader1961 krader1961 deleted the issue-1749-check-rellinks branch January 23, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The website/tools/check-rellinks.py program has a surprising quirk regarding links that end in a slash
2 participants