Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README correction and until method #4

Merged
merged 2 commits into from
Nov 15, 2012
Merged

README correction and until method #4

merged 2 commits into from
Nov 15, 2012

Conversation

iamyellow
Copy link
Contributor

Hi,

1st of all, thanks for you sugar work :)

Just a couple of things:

  • require('wait') -as reflected in README- does not work in NodeJS as the npm package name is waitjs
  • IMO .until method should first check if condition is true, if not then setup the .repeat

Thanks!

elving added a commit that referenced this pull request Nov 15, 2012
@elving
Merge pull request #4 from iamyellow/master
982ab33 
README correction and until method
@elving elving merged commit 982ab33 into elving:master Nov 15, 2012
@elving
Copy link
Owner

elving commented Nov 15, 2012

Nice! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamyellow @elving