Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #5 #7

Closed
wants to merge 1 commit into from
Closed

Implement #5 #7

wants to merge 1 commit into from

Conversation

vendethiel
Copy link

No description provided.

@elving
Copy link
Owner

elving commented Jan 23, 2014

Hmm I see your problem now. So the reason it wasn't working for you is because maybe you were doing this:

var wait = require('waitjs');

When your suppose to do this:

require('waitjs');

In node, var root = this; means var root = global; and in the browser it means var root = window;. So wait is added to the global object in node, the module doesn't returns anything. Also the tests are not passing so I'm gonna close the PR for now.

@elving elving closed this Jan 23, 2014
@vendethiel
Copy link
Author

Not global, exports. Two different things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants