Adding ability to recognize more cities #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Brazilian cities like "São Paulo", "Carapicuíba" and other was not passing on old "city_regex". Example using last version: ``` >>> text = "São Paulo é a capital do estado de São Paulo. As cidades de Baru erí e Carapicuíba fazem parte da Grade São Paulo. O Rio de Janeiro continua lindo. No carnaval eu vou para Salvador. No reveillon eu quero ir para Santo s." >>> old_result = GeoText(text) >>> old_result.cities ['Salvador', 'Santos'] >>> ``` Considering the same text, using this "new" regex we have: ``` >>> result.cities ['S\xc3\xa3o Paulo', 'S\xc3\xa3o Paulo', 'As', 'Baruer\xc3\xad', 'Carapicu\x c3\xadba', 'Grade S\xc3\xa3o Paulo', 'O Rio', 'Janeiro', 'No', 'Salvador', ' No', 'Santos'] ``` I think this change can be useful to recognize other cities in the world.
|
Hi José, muito obrigado, :-) Looks great, I will add some tests and if everything passes will merge right away. Thanks again |
|
👍 |
|
Added to the 0.3.0 release in pypi. Thanks a lot for making geotext better. |
felipecwb
reviewed
Mar 14, 2017
| @@ -103,7 +103,7 @@ class GeoText(object): | |||
| index = build_index() | |||
|
|
|||
| def __init__(self, text): | |||
| city_regex = r"[A-Z]+[a-z]*(?:[ '-][A-Z]+[a-z]*)*" | |||
| city_regex = r"[A-Z]+[a-zà-ú]*(?:[ '-][A-Z]+[a-zà-ú]*)*" | |||
There was a problem hiding this comment.
@joseluizcoe I see that it cannot recognize cities with the first accented char like "Água Clara" or "Érico Cardoso"
Maybe [A-Z\À-\Ú] for these first chars can deal with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Brazilian cities like "São Paulo", "Carapicuíba" and other was not passing on old "city_regex".
Example using last version:
Considering the same text, using this "new" regex we have:
I think this change can be useful to recognize other cities in the world.