Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new strategy for batch uuids queue which will perform request as soon as batch size limit will be filled #24

Closed
erickskrauch opened this issue Apr 23, 2020 · 0 comments · Fixed by #25
Closed

Add a new strategy for batch uuids queue which will perform request as soon as batch size limit will be filled #24

erickskrauch opened this issue Apr 23, 2020 · 0 comments · Fixed by #25
Assignees
@erickskrauch
Labels
enhancement New feature or request
Milestone
4.5.0

Comments

@erickskrauch
Copy link
Member

This strategy will allow for a faster return of results in case of load bursts. The idea is as follows: the strategy will send a request as soon as there are n elements in the queue or until t time has passed since the first element appeared for processing.

Explaining for humans: people from the CIS should easily understand this logic by drawing an analogy with the drivers of the route: until a full car is filled, it will not go 😅
@erickskrauch erickskrauch added the enhancement New feature or request label Apr 23, 2020
@erickskrauch erickskrauch added this to the 4.5.0 milestone Apr 23, 2020
@erickskrauch erickskrauch self-assigned this Apr 23, 2020
erickskrauch added a commit that referenced this issue Apr 24, 2020
@erickskrauch
Extracted strategy from batch uuids provider implementation.
29b6bc8 
Reimplemented Periodic strategy.
Implemented FullBus strategy (#24).
Started working on tests.
@erickskrauch erickskrauch mentioned this issue Apr 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erickskrauch erickskrauch

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

FullBus stategy elyby/chrly
1 participant
@erickskrauch