Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install by updating to best practices #28

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Fix install by updating to best practices #28

merged 1 commit into from
Feb 10, 2017

Conversation

nathancahill
Copy link
Contributor

Fixes a couple things to use Rollup's updated best practices (also fixed the broken install for me).

  1. Switch from babel-preset-es2015-rollup to babel-preset-es2015 with "modules": false. Recommended.

  2. Include external-helpers in .babelrc. Recommended.

  3. Switch from build/build.js to rollup.config.js Recommended.

@nathancahill nathancahill mentioned this pull request Jan 31, 2017
Closed
@differui differui merged commit 30b6ab3 into elycruz:master Feb 10, 2017
@differui
Copy link
Contributor

differui commented Feb 10, 2017 •
edited
Loading

new version 0.4.9.

@nathancahill nathancahill deleted the fixes/broken-install branch February 11, 2017 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathancahill @differui