Convert --valid-only to --include-invalid on list subcommand #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Bates <kbates4@gmail.com>
kevin-bates
force-pushed
the
include-invalid
branch
from
33a4f37
to
46f9ed1
Compare
lresende
approved these changes
Mar 31, 2023
ptitzler
added
component:cli-tools
ptitzler
changed the title
ptitzler
requested changes
Apr 3, 2023
There was a problem hiding this comment.
Confirmed that the code changes work as expected, but noticed missing documentation updates. The "listing XXX" sections in the CLI user guide include examples that no longer reflect the new default behavior:
- https://github.com/elyra-ai/elyra/blob/main/docs/source/user_guide/code-snippets.md#listing-code-snippets
- https://github.com/elyra-ai/elyra/blob/main/docs/source/user_guide/pipeline-components.md#managing-custom-components-using-the-elyra-cli
- https://github.com/elyra-ai/elyra/blob/main/docs/source/user_guide/runtime-conf.md#listing-runtime-configurations
- https://github.com/elyra-ai/elyra/blob/main/docs/source/user_guide/runtime-image-conf.md#managing-runtime-image-configurations-using-the-elyra-cli
|
I added an entry to the breaking changes section in the release notes draft, which documents the changes and required actions. |
Signed-off-by: Kevin Bates <kbates4@gmail.com>
|
Ah, right, forgot to check the docs. Thanks. Docs have been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the
elyra-metadata listcommand's--valid-onlyoption with--include-invalidto make the command more intuitive. With this change, invalid instances are not listed by default. Instead, only valid instances are listed and the user must include option--include-invalidto have invalid instances included in the output.The tests were updated accordingly.
Resolves: #2562