-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scripts #99
Update scripts #99
Conversation
What was wrong with create-release.py? |
It was the only piece of code that used python. To run it, you need to have python installed, set up an env, and figure out what dependencies need to be installed (semantic_version needed to be pip installed). Additionally, linting and formatting is set up for typescript, but we don’t have anything similar set up for python (and feels like overkill to set up for one script). I would be a bit more okay to keep create_release.py if it worked out-of-the-box, but still would prefer to keep this project one language. |
@lresende I broke up the |
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 88.53% 87.93% -0.61%
==========================================
Files 22 29 +7
Lines 759 1094 +335
Branches 172 245 +73
==========================================
+ Hits 672 962 +290
- Misses 70 97 +27
- Partials 17 35 +18
Continue to review full report at Codecov.
|
2c3488e
to
a5922ae
Compare
Outdated |
This PR:
watch
script to the package.jsoncreate-release.py
to typescriptcreate-release.py
doesn't publish a valid package)--dry-run
flag to test run without doing anything destructiveDeveloper's Certificate of Origin 1.1