Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-select broke #39

Closed
bdarcus opened this issue Mar 22, 2021 · 1 comment · Fixed by #40
Closed

multi-select broke #39

bdarcus opened this issue Mar 22, 2021 · 1 comment · Fixed by #40
Labels
bug Something isn't working

Comments

@bdarcus
Copy link
Contributor

bdarcus commented Mar 22, 2021

Selection of multiple candidates broke (returns empty results), as a result of this change. I guess I didn't test it enough.

The first result below is with a single selection, and the other with two.

ELISP> (bibtex-actions-read)
("sassen2000")

ELISP> (bibtex-actions-read)
(nil nil)

I've established the problem is with --get-candidates.

@bdarcus bdarcus added the bug Something isn't working label Mar 22, 2021
@bdarcus
Copy link
Contributor Author

bdarcus commented Mar 22, 2021

@clemera - before I dig into this further, did you change anything with crm in the past few days? I see your latest commit fixed a crm-related issue, but I'm running that commit.

EDIT: nevermind. I rolled back to the selectrum commit I know worked, and the problem persists, so must be in my code.

bdarcus added a commit that referenced this issue Mar 22, 2021
@bdarcus bdarcus mentioned this issue Mar 23, 2021
@bdarcus bdarcus changed the title multi-select broke? multi-select broke Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant