Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add key to "invisible" part of candidate to ensure uniqueness #55

Closed
bdarcus opened this issue Apr 3, 2021 · 0 comments · Fixed by #56
Closed

add key to "invisible" part of candidate to ensure uniqueness #55

bdarcus opened this issue Apr 3, 2021 · 0 comments · Fixed by #56

Comments

@bdarcus
Copy link
Contributor

bdarcus commented Apr 3, 2021

This may be overthinking things, but the approach here now is that the candidate search string is configured with the two defcustoms. While there are sensible defaults there, it might be feasible that a user configures these in such a way that the candidates are not all unique. For example, say they nil the suffix, and some records don't have titles.

Potential simple solution: add the key to the "invisible" section of the candidate.
bdarcus added a commit that referenced this issue Apr 3, 2021
@bdarcus
add citekey to invisible candidate string
43f5e93 
In theory, a user can now configure the candidate strings in such a way
that, with certain records, candidates may not be unique. This ensures
that doesn't happen.

fix #55
@bdarcus bdarcus mentioned this issue Apr 3, 2021
Merged
bdarcus added a commit that referenced this issue Apr 3, 2021
@bdarcus
add citekey to invisible candidate string (#56)
12f3b02 
In theory, a user can now configure the candidate strings in such a way
that, with certain records, candidates may not be unique. This ensures
that doesn't happen.

fix #55
@bdarcus bdarcus changed the title add key to "invisible" part of candidate to ensure uniqueness? add key to "invisible" part of candidate to ensure uniqueness Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add citekey to invisible candidate string emacs-citar/citar
1 participant
@bdarcus