[Fix #116] Add types for some functions in process.c

[DamienCassou]

No description provided.

[Fuco1]

Thanks for this! But let's wait until #74 is solved so we don't have to re-do this again. I'm not sure if we can get a feasible automatic script going faster than doing the convertion manually.

I want to finish the proposal over the weekend and do the transition.

[DamienCassou]

Matus Goljer <notifications@github.com> writes:

Thanks for this! But let's wait until #74 is solved so we don't have to re-do this again. I'm not sure if we can get a feasible automatic script going faster than doing the convertion manually.

you already have a parser for the old syntax. What you need for the conversion script is a pretty-printer but you might have that already to display error messages.

…

-- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill

[Fuco1]

Actually you're right. I can modify the pretty-printer and then write some crazy regexp/reader while loop that would go over the source code.

I think I could do that in under an hour.

[Fuco1]

Can you copy the process.c section from https://github.com/emacs-elsa/Elsa/blob/master/dev/builtin.txt#L649 and replace the lines you implemented with the code and keep the rest commented.

This is so we don't miss anything.

Then I think we can go ahead and merge as per the discussion above.

[DamienCassou]

Can you copy the process.c section...

done.

Is it possible to define a type Process before merging that PR or within that PR? I'm a bit annoyed by this kind of signature:

(put 'get-process 'elsa-type (elsa-make-type String -> Mixed))

because Mixed should indeed be Process instead.

[Fuco1]

There's an issue for that #31

I should really copy all the types there so we can track the progress easier, currently I only link to the categories.

To add a new primitive types this should be all that's required:

(defclass elsa-type-buffer (elsa-type) ())

(cl-defmethod elsa-type-describe ((this elsa-type-buffer))
  "Buffer")

That is, the class to represent the type and the describe method (pretty printer). The type constructor is then the suffix after elsa-type- capitalized.

Go ahead and add it to this PR, so long as it is a separate commit I have no problem with that.

[DamienCassou]

I added all types in #118.

[DamienCassou]

I updated the PR with the new Process type. Some questions:

• what should I specify as return type if the documentation doesn't say anything? For example, set-process-filter. Looking at the source code, the second parameter seems to be returned but I'm not sure we should use that as a type.
• should I keep repeating (Process -> String -> Nil) as parameter or return value, or should I define a ProcessFilter type?
• what should I do about optional arguments such as in (process-contact PROCESS &optional KEY)?
• what should I do to specify a PList type of symbol keys and mixed values? E.g., in process-plist or set-process-plist.
• what should I do to specify make-process which takes key/value pairs as an &rest ARGS.

[Fuco1]

If we don't know the return type use Mixed for now. I'm still not sold on the void concept.

About the ProcessFilter, there is no way to declare custom types now, I've just realized the same thing and opened #119 literally 3 minutes ago :D And I would prefer not to have these defined with the defclass stuff. We should have a way to build types from the primitive types somehow.

Right now optional arguments are the same as nullable but it's not really the same thing. Declare it nullable and add a TODO that we need to fix it later.

For the last two, we don't have support for plists so go with lists of mixed for now.

I'll link this to the typespec issue since these are valid issues to be addressed.

[DamienCassou]

I did my best to cover all functions (except process-connection which is disabled in the C source code).

[Fuco1]

@DamienCassou Sweet, one less to go. I'll review it but I don't expect much issues.

[Fuco1]

I've rebased and merged the commits into master.