Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIDER: Use conditionaly use xref-find-definitions in the goto definitions keybind #776

Closed
toniz4 opened this issue Feb 5, 2024 · 1 comment · Fixed by #782
Closed

CIDER: Use conditionaly use xref-find-definitions in the goto definitions keybind #776

toniz4 opened this issue Feb 5, 2024 · 1 comment · Fixed by #782

Comments

@toniz4
Copy link
Contributor

toniz4 commented Feb 5, 2024

Starting in at version 1.2.0, CIDER's main method of finding definitions is using the builtin emacs xref-find-definitions, unless the variable cider-use-xref is nil, the default being t.

It would be nice if we could mirror this functionality in evil collection.

evil-collection/modes/cider/evil-collection-cider.el

Line 135 in 29212d1

"gd" 'cider-find-var

If it's something you wish to add, I will be happy to make a PR.
@condy0919
Copy link
Collaborator

PR welcome.

toniz4 added a commit to toniz4/evil-collection that referenced this issue Mar 1, 2024
@toniz4
CIDER: Only use cider-find-var when cider-use-xref is nil
e9d46f2 
Closes: emacs-evil#776
@toniz4 toniz4 mentioned this issue Mar 1, 2024
Merged
condy0919 pushed a commit that referenced this issue Mar 5, 2024
@toniz4 @condy0919
CIDER: Only use cider-find-var when cider-use-xref is nil
5bb5ada 
Closes: #776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CIDER: Only use cider-find-var when cider-use-xref is nil toniz4/evil-collection
2 participants
@condy0919 @toniz4