Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedbar makes helm change focus to helm window #257

Closed
hrehfeld opened this issue Jul 17, 2013 · 14 comments
Closed

Speedbar makes helm change focus to helm window #257

hrehfeld opened this issue Jul 17, 2013 · 14 comments
Labels

Comments

@hrehfeld
Copy link

when I start speedbar, I experience problems similar to this: #163

GNU Emacs 24.2.1 (i386-mingw-nt6.1.7601) of 2012-08-29 on MARVIN
(on windows)

Steps to reproduce:
emacs -Q
(require 'helm-config)
(helm-mode t)
(speedbar t)
M-x something
wait until helm buffer updates

@thierryvolpiatto
Copy link
Member

I can't reproduce, should be working on Emacs-24.3.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

@iani
Copy link

iani commented Aug 12, 2013

I confirm that this bug / problem occurs. helm-mini cannot be used when speedbar is open. Configuration: Emacs 24.3, version emacsformacosx. Helm and speedbar installed via Prelude. Open speedbar with M-x speedbar. Then start helm-mini with M-x helm-mini. The cursor keeps returning to the helm-mini main window which shows the list of files/paths. Typing results in modifying the contents of this buffer. Clicking on the minibuffer-line to return focus to the minibuffer does not work, as the cursor returns to the helm-mini main window after a very small interval. Practically this means that speedbar is incompatible with helm-mini. You cannot use both together.

Note: thierryvolpiatto above says that on Emacs 24.3 this problem should not occur, but this is not true. The issue does persist on Emacs 24.3.

Workaround: Use either helm-mini or speedbar at a time, not both together.

Iannis Zannos

@thierryvolpiatto
Copy link
Member

So this seems to be platform specific as it is not reproductible on
GNU/Linux.(emacs-24.3, emacs-24.3.50.1).

Did you try a development version of Emacs (24.3.50.1)?

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

thierryvolpiatto pushed a commit that referenced this issue Aug 18, 2013
(helm-internal): no need to set cursor-in-echo-area here.
@thierryvolpiatto
Copy link
Member

Tried to fix this on windowsXP, without success, looks more a bug in either Emacs-24.2 and also all emacs >=24.3 on windows-nt and probably on mac-osx as reported above, than an helm bug.

thierryvolpiatto pushed a commit that referenced this issue Aug 18, 2013
#257;

Seems that with same fix as previous attempt but using lambda and not function lambda fix problem.
thierryvolpiatto pushed a commit that referenced this issue Aug 18, 2013
Use (lambda in first place and #'(lambda in second place.
thierryvolpiatto pushed a commit that referenced this issue Aug 18, 2013
(helm-check-minibuffer-timer-fn): New.
(helm-read-pattern-maybe): use it
@thierryvolpiatto
Copy link
Member

Looks like the compiler produce a code behaving differently if the code source file is encoded with DOS or UNIX.
The last fixes worked fine on Windows with helm.el encoded to mule-utf-8-dos, but the bug still there with same code compiled with helm.el encoded to mule-utf-8-unix. Weird, really an emacs bug.

@thierryvolpiatto
Copy link
Member

Can someone try on Windows or mac-osx with helm not compiled (remove all *.elc files from helm directory).
Use the exp branch.

Thanks.

@thierryvolpiatto
Copy link
Member

I have reverted changes, use the master branch sorry.

@thierryvolpiatto
Copy link
Member

Ok definitely, using non--compiled helm files fix the problem.

@thierryvolpiatto
Copy link
Member

On WindowsXP, I have updated my helm directory (master branch) REMOVED all *.elc files, recompiled with make, and now the problem is fixed, it is working as expected, no more lose of focus.

@iani
Copy link

iani commented Aug 20, 2013

Cannot test this fix for MacOS currently. I should be able to do this next week though.
IZ

@thierryvolpiatto
Copy link
Member

Not really a fix though, the code is just working not compiled.
Probably an Emacs bug.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

@thierryvolpiatto
Copy link
Member

I sent a bug report on Emacs bug, follow here:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15288

@thierryvolpiatto
Copy link
Member

So on WindowsXP I consider the bug is fixed:
Just verify your PATH env var is updated to the last Emacs you are using, run make again.
I close the bug now, feel free to reopen if you can't fix the problem like this.

@iani
Copy link

iani commented Mar 24, 2014

This is fixed on my system on MacOs running the latest version of Emacsformacosx. No more problems with Speedbar.
IZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants