helm broken on Emacs master

[michael-heerdegen]

I checked out the lastest commit of the master branch of Emacs, which is:

50c117f * HEAD origin/master origin/HEAD master EIEIO: Change class's representation to unify instance & class slots

After that, helm was broken. I called "make" for helm again, got these warnings while making:

rm -f helm-adaptive.elc helm-aliases.elc helm-apt.elc helm-autoloads.elc helm-bookmark.elc helm-buffers.elc helm-color.elc helm-command.elc helm-config.elc helm-dabbrev.elc helm-elisp-package.elc helm-elisp.elc helm-elscreen.elc helm-eshell.elc helm-eval.elc helm-external.elc helm-files.elc helm-font.elc helm-grep.elc helm-help.elc helm-imenu.elc helm-info.elc helm-locate.elc helm-man.elc helm-match-plugin.elc helm-misc.elc helm-mode.elc helm-net.elc helm-org.elc helm-pkg.elc helm-plugin.elc helm-regexp.elc helm-ring.elc helm-semantic.elc helm-source.elc helm-sys.elc helm-tags.elc helm-utils.elc helm.elc
emacs -Q -batch --eval "(let ((generated-autoload-file (expand-file-name \"helm-autoloads.el\" \".\")) \
(backup-inhibited t)) (update-directory-autoloads \".\"))"
emacs -Q -batch -L . -f batch-byte-compile helm-adaptive.el helm-aliases.el helm-apt.el helm-autoloads.el helm-bookmark.el helm-buffers.el helm-color.el helm-command.el helm-config.el helm-dabbrev.el helm-elisp-package.el helm-elisp.el helm-elscreen.el helm-eshell.el helm-eval.el helm-external.el helm-files.el helm-font.el helm-grep.el helm-help.el helm-imenu.el helm-info.el helm-locate.el helm-man.el helm-match-plugin.el helm-misc.el helm-mode.el helm-net.el helm-org.el helm-pkg.el helm-plugin.el helm-regexp.el helm-ring.el helm-semantic.el helm-source.el helm-sys.el helm-tags.el helm-utils.el helm.el

In toplevel form:
helm-bookmark.el:23:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In toplevel form:
helm-command.el:22:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In toplevel form:
helm-dabbrev.el:21:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In helm-el-package-upgrade-all:
helm-elisp-package.el:178:9:Warning: reference to free variable
    `helm-marked-buffer-name'

In toplevel form:
helm-elisp.el:22:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In toplevel form:
helm-eshell.el:28:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In end of data:
helm-external.el:217:1:Warning: the function `helm-comp-read' is not known to
    be defined.

In toplevel form:
helm-files.el:27:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In helm-grep--prepare-cmd-line:
helm-grep.el:344:51:Warning: reference to free variable
    `helm-ff-default-directory'
helm-grep.el:386:1:Warning: Unused lexical variable `tramp-verbose'

In helm-grep-init:
helm-grep.el:388:51:Warning: reference to free variable
    `helm-ff-default-directory'
helm-grep.el:393:25:Warning: reference to free variable `helm-tramp-verbose'

In helm-grep-action:
helm-grep.el:482:43:Warning: reference to free variable
    `helm-ff-default-directory'

In helm-do-grep-1:
helm-grep.el:846:14:Warning: reference to free variable
    `helm-ff-default-directory'
helm-grep.el:923:25:Warning: assignment to free variable
    `helm-ff-default-directory'

In helm-ff-zgrep-1:
helm-grep.el:935:28:Warning: reference to free variable
    `helm-ff-default-directory'

In helm-grep-filter-one-by-one:
helm-grep.el:991:29:Warning: reference to free variable
    `helm-ff-default-directory'
helm-grep.el:1023:1:Warning: Unused lexical variable `helm-ff-default-directory'

In helm-grep-buffers-1:
helm-grep.el:1031:11:Warning: reference to free variable
    `helm-ff-default-directory'

In helm-pdfgrep-init:
helm-grep.el:1074:33:Warning: reference to free variable
    `helm-ff-default-directory'

In helm-do-pdfgrep-1:
helm-grep.el:1127:31:Warning: reference to free variable
    `helm-ff-default-directory'
helm-grep.el:1127:61:Warning: assignment to free variable
    `helm-ff-default-directory'

In helm-do-grep:
helm-grep.el:1172:40:Warning: reference to free variable
    `helm-ff-transformer-show-only-basename'

In helm-do-zgrep:
helm-grep.el:1190:35:Warning: reference to free variable
    `helm-ff-transformer-show-only-basename'

In helm-do-pdfgrep:
helm-grep.el:1210:37:Warning: reference to free variable
    `helm-ff-transformer-show-only-basename'

In end of data:
helm-grep.el:1226:1:Warning: the following functions are not known to be
    defined: helm-comp-read, helm-read-file-name

In helm-ff-find-locatedb:
helm-locate.el:126:17:Warning: reference to free variable
    `helm-ff-default-directory'

In helm-locate-1:
helm-locate.el:158:36:Warning: reference to free variable
    `helm-ff-default-directory'
helm-locate.el:196:1:Warning: Unused lexical variable `helm-ff-transformer-show-only-basename'
helm-locate.el:298:1:Warning: Unused lexical variable `helm-ff-transformer-show-only-basename'

In helm-locate:
helm-locate.el:333:9:Warning: assignment to free variable
    `helm-ff-default-directory'

In end of data:
helm-locate.el:345:1:Warning: the function `helm-read-file-name' is not known
    to be defined.

In end of data:
helm-man.el:103:1:Warning: the function `helm-comp-read' is not known to be
    defined.

In toplevel form:
helm-misc.el:292:1:Warning: Unused lexical variable `helm-ff-transformer-show-only-basename'

In helm-mini:
helm-misc.el:296:11:Warning: reference to free variable
    `helm-source-buffers-list'
helm-misc.el:297:11:Warning: assignment to free variable
    `helm-source-buffers-list'

In toplevel form:
helm-mode.el:22:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In end of data:
helm-net.el:608:1:Warning: the function `helm-comp-read' is not known to be
    defined.

In end of data:
helm-regexp.el:626:1:Warning: the following functions are not known to be
    defined: helm-buffer-list, helm-comp-read

In toplevel form:
helm-ring.el:23:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In toplevel form:
helm-semantic.el:27:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In toplevel form:
helm-source.el:765:24:Warning: reference to free variable `helm-bookmark-map'

In end of data:
helm-source.el:1121:1:Warning: the function `helm-ediff-marked-buffers' is not
    known to be defined.

In helm-quit-and-find-file:
helm-utils.el:381:34:Warning: reference to free variable
    `helm-ff-transformer-show-only-basename'
helm-utils.el:405:50:Warning: reference to free variable `ffap-url-regexp'

In helm-ff-get-host-from-tramp-invalid-fname:
helm-utils.el:524:54:Warning: reference to free variable `tramp-methods'

In end of data:
helm.el:5193:1:Warning: the function `helm-file-completion-source-p' is not
    known to be defined.
Makefile:56: recipe for target 'batch-compile' failed
make: *** [batch-compile] Error 1

When I execute helm.sh, it says

rm -f helm-adaptive.elc helm-aliases.elc helm-apt.elc helm-autoloads.elc helm-bookmark.elc helm-buffers.elc helm-color.elc helm-command.elc helm-config.elc helm-dabbrev.elc helm-elisp-package.elc helm-elisp.elc helm-elscreen.elc helm-eshell.elc helm-eval.elc helm-external.elc helm-files.elc helm-font.elc helm-grep.elc helm-help.elc helm-imenu.elc helm-info.elc helm-locate.elc helm-man.elc helm-match-plugin.elc helm-misc.elc helm-mode.elc helm-net.elc helm-org.elc helm-pkg.elc helm-plugin.elc helm-regexp.elc helm-ring.elc helm-semantic.elc helm-source.elc helm-sys.elc helm-tags.elc helm-utils.elc helm.elc
emacs -Q -batch --eval "(let ((generated-autoload-file (expand-file-name \"helm-autoloads.el\" \".\")) \
(backup-inhibited t)) (update-directory-autoloads \".\"))"
emacs -Q -batch -L . -f batch-byte-compile helm-adaptive.el helm-aliases.el helm-apt.el helm-autoloads.el helm-bookmark.el helm-buffers.el helm-color.el helm-command.el helm-config.el helm-dabbrev.el helm-elisp-package.el helm-elisp.el helm-elscreen.el helm-eshell.el helm-eval.el helm-external.el helm-files.el helm-font.el helm-grep.el helm-help.el helm-imenu.el helm-info.el helm-locate.el helm-man.el helm-match-plugin.el helm-misc.el helm-mode.el helm-net.el helm-org.el helm-pkg.el helm-plugin.el helm-regexp.el helm-ring.el helm-semantic.el helm-source.el helm-sys.el helm-tags.el helm-utils.el helm.el

In toplevel form:
helm-bookmark.el:23:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In toplevel form:
helm-command.el:22:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In toplevel form:
helm-dabbrev.el:21:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In helm-el-package-upgrade-all:
helm-elisp-package.el:178:9:Warning: reference to free variable
    `helm-marked-buffer-name'

In toplevel form:
helm-elisp.el:22:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In toplevel form:
helm-eshell.el:28:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In end of data:
helm-external.el:217:1:Warning: the function `helm-comp-read' is not known to
    be defined.

In toplevel form:
helm-files.el:27:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In helm-grep--prepare-cmd-line:
helm-grep.el:344:51:Warning: reference to free variable
    `helm-ff-default-directory'
helm-grep.el:386:1:Warning: Unused lexical variable `tramp-verbose'

In helm-grep-init:
helm-grep.el:388:51:Warning: reference to free variable
    `helm-ff-default-directory'
helm-grep.el:393:25:Warning: reference to free variable `helm-tramp-verbose'

In helm-grep-action:
helm-grep.el:482:43:Warning: reference to free variable
    `helm-ff-default-directory'

In helm-do-grep-1:
helm-grep.el:846:14:Warning: reference to free variable
    `helm-ff-default-directory'
helm-grep.el:923:25:Warning: assignment to free variable
    `helm-ff-default-directory'

In helm-ff-zgrep-1:
helm-grep.el:935:28:Warning: reference to free variable
    `helm-ff-default-directory'

In helm-grep-filter-one-by-one:
helm-grep.el:991:29:Warning: reference to free variable
    `helm-ff-default-directory'
helm-grep.el:1023:1:Warning: Unused lexical variable `helm-ff-default-directory'

In helm-grep-buffers-1:
helm-grep.el:1031:11:Warning: reference to free variable
    `helm-ff-default-directory'

In helm-pdfgrep-init:
helm-grep.el:1074:33:Warning: reference to free variable
    `helm-ff-default-directory'

In helm-do-pdfgrep-1:
helm-grep.el:1127:31:Warning: reference to free variable
    `helm-ff-default-directory'
helm-grep.el:1127:61:Warning: assignment to free variable
    `helm-ff-default-directory'

In helm-do-grep:
helm-grep.el:1172:40:Warning: reference to free variable
    `helm-ff-transformer-show-only-basename'

In helm-do-zgrep:
helm-grep.el:1190:35:Warning: reference to free variable
    `helm-ff-transformer-show-only-basename'

In helm-do-pdfgrep:
helm-grep.el:1210:37:Warning: reference to free variable
    `helm-ff-transformer-show-only-basename'

In end of data:
helm-grep.el:1226:1:Warning: the following functions are not known to be
    defined: helm-comp-read, helm-read-file-name

In helm-ff-find-locatedb:
helm-locate.el:126:17:Warning: reference to free variable
    `helm-ff-default-directory'

In helm-locate-1:
helm-locate.el:158:36:Warning: reference to free variable
    `helm-ff-default-directory'
helm-locate.el:196:1:Warning: Unused lexical variable `helm-ff-transformer-show-only-basename'
helm-locate.el:298:1:Warning: Unused lexical variable `helm-ff-transformer-show-only-basename'

In helm-locate:
helm-locate.el:333:9:Warning: assignment to free variable
    `helm-ff-default-directory'

In end of data:
helm-locate.el:345:1:Warning: the function `helm-read-file-name' is not known
    to be defined.

In end of data:
helm-man.el:103:1:Warning: the function `helm-comp-read' is not known to be
    defined.

In toplevel form:
helm-misc.el:292:1:Warning: Unused lexical variable `helm-ff-transformer-show-only-basename'

In helm-mini:
helm-misc.el:296:11:Warning: reference to free variable
    `helm-source-buffers-list'
helm-misc.el:297:11:Warning: assignment to free variable
    `helm-source-buffers-list'

In toplevel form:
helm-mode.el:22:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In end of data:
helm-net.el:608:1:Warning: the function `helm-comp-read' is not known to be
    defined.

In end of data:
helm-regexp.el:626:1:Warning: the following functions are not known to be
    defined: helm-buffer-list, helm-comp-read

In toplevel form:
helm-ring.el:23:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In toplevel form:
helm-semantic.el:27:1:Error: Wrong type argument: symbol, [cl-struct-cl-slot-descriptor name nil t ((:documentation . "  The name of the source.
  A string which is also the heading which appears
  above the list of matches from the source. Must be unique.") (:custom . string) (:group default))], slot

In toplevel form:
helm-source.el:765:24:Warning: reference to free variable `helm-bookmark-map'

In end of data:
helm-source.el:1121:1:Warning: the function `helm-ediff-marked-buffers' is not
    known to be defined.

In helm-quit-and-find-file:
helm-utils.el:381:34:Warning: reference to free variable
    `helm-ff-transformer-show-only-basename'
helm-utils.el:405:50:Warning: reference to free variable `ffap-url-regexp'

In helm-ff-get-host-from-tramp-invalid-fname:
helm-utils.el:524:54:Warning: reference to free variable `tramp-methods'

In end of data:
helm.el:5193:1:Warning: the function `helm-file-completion-source-p' is not
    known to be defined.
Makefile:56: recipe for target 'batch-compile' failed
make: *** [batch-compile] Error 1

and helm-mode is not enabled.

[michael-heerdegen]

I reverted to the parent commit of 50c117f (emacs), that one doesn't even build...

[michael-heerdegen]

I reverted to "1a93b91 * HEAD * lisp/net/browse-url.el: Omit confusing documentation.". Builds ok and helm makes and works ok, too.

[thierryvolpiatto]

Michael Heerdegen notifications@github.com writes:

I reverted to the parent commit of 50c117f (emacs), that one doesn't even build...

The problems should start at 872481d.

I don't have the time to build a new emacs and try, I will have a look
tomorrow.

BTW I sent a bugreport to emacs.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

[thierryvolpiatto]

Thierry Volpiatto thierry.volpiatto@gmail.com writes:

Michael Heerdegen notifications@github.com writes:

I reverted to the parent commit of 50c117f (emacs), that one doesn't even build...

The problems should start at 872481d.

I don't have the time to build a new emacs and try, I will have a look
tomorrow.

BTW I sent a bugreport to emacs.

Using set-slot-value' instead ofoset' works fine, so I guess `oset' is
broken in emacs-25.

Michael, can you confirm ?
(I will commit in a few minutes)

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

[thierryvolpiatto]

Reference to emacs bugreport:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20141

[michael-heerdegen]

No, that doesn't fix it here.

[michael-heerdegen]

The issue has apparently been fixed in Emacs; helm seems to work ok now.