Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AUCTeX's new mode naming convention #41

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

Rathur421
Copy link
Contributor

Hi, thanks for maintaining this package, it's great!

To quote this other pull request :

Recently, AUCTeX renamed several of its major modes to avoid shadowing emacs built-in modes. This is documented here: https://git.savannah.gnu.org/cgit/auctex.git/tree/doc/changes.texi

As a result, if one has the newer version of AUCTeX (the version currently available from ELPA) then when they activate LaTeX-mode, lsp will be unavailable.

So I just added LaTeX-mode to the variable lsp-ltex-active-modes and it's working.

Also, I was wondering if we shouldn't add by default the other latex mode (i.e. TeX-mode, tex-mode and yatex-mode)

lsp-ltex.el Outdated
@@ -50,7 +50,8 @@ https://github.com/valentjn/ltex-ls"

(defcustom lsp-ltex-active-modes
'( text-mode
bibtex-mode context-mode latex-mode
bibtex-mode context-mode
latex-mode LaTeX mode ;; AUCTeX 14+ has renamed latex-mode to LaTeX-mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a - here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, I did the fix quickly on GitHub and didn't even consider it as a possible mistake

@jcs090218
Copy link
Member

Also, I was wondering if we shouldn't add by default the other latex mode (i.e. TeX-mode, tex-mode and yatex-mode)

If those major modes work, we should add them by default.

@jcs090218 jcs090218 merged commit 9784627 into emacs-languagetool:master Feb 26, 2024
14 of 15 checks passed
@jcs090218
Copy link
Member

Thanks!

@Rathur421
Copy link
Contributor Author

If those major modes work, we should add them by default.

Just to let you know, I've made a bit of digging and I didn't see any TeX-mode which are really used around.
The emacs manual says that it only provides major mode variant. As for yatex-mode it seems like it's a japanese package which is still being updated regularly (last update 7 months ago). So maybe it is worth adding it, but I'll let you choose.

Sorry for the late answer, and thanks again for maintaining this package !

@jcs090218
Copy link
Member

Just to let you know, I've made a bit of digging and I didn't see any TeX-mode which are really used around.
The emacs manual says that it only provides major mode variant. As for yatex-mode it seems like it's a japanese package which is still being updated regularly (last update 7 months ago). So maybe it is worth adding it, but I'll let you choose.

Feel free to open PRs for these major modes! :)

@Rathur421 Rathur421 deleted the Handle-LaTeX-mode branch April 10, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants